Skip to content
1        10        20        30        40        50        60        70        80        90        1001use actix_identity::IdentityMiddleware;2use actix_session::{SessionMiddleware, config::PersistentSession};3use actix_web::cookie::Cookie;4use actix_web::http::StatusCode;5use actix_web::test as aw_test;6use actix_web::{App, cookie::time::Duration, web};7use serde::Serialize;89use crate::auth::SESSION_COOKIE_NAME;10use crate::config::Config;11use crate::db::Database;1213#[derive(Serialize)]14struct Signup<'a> {15    username: &'a str,16    email: &'a str,17    password: &'a str,18    invite: &'a str,19}2021#[derive(Serialize)]22struct CreateInvite<'a> {23    invite_secret: &'a str,24}2526#[derive(Serialize)]27struct Login<'a> {28    username: &'a str,29    password: &'a str,30}3132async fn setup() -> (Database, Config, String) {33    let db_path = format!("/tmp/test_pear_it_{}.db", uuid::Uuid::new_v4());34    let db = Database::new(&db_path);35    db.init().await.expect("init db");36    let mut config = Config::new(8080, None, db_path.clone(), false);37    config.invite_secret = Some("test-invite-secret".to_string());38    db.create_invite("test-invite")39        .await40        .expect("create test invite");41    (db, config, db_path)42}4344fn cleanup(path: &str) {45    for suffix in ["", "-shm", "-wal"] {46        let _ = std::fs::remove_file(format!("{path}{suffix}"));47    }48}4950macro_rules! test_app {51    ($db:expr, $config:expr) => {52        aw_test::init_service(53            App::new()54                .wrap(IdentityMiddleware::default())55                .wrap(56                    SessionMiddleware::builder(57                        crate::db::session_store::SqliteSessionStore::new($db.clone()),58                        ($config).session_key.clone(),59                    )60                    .cookie_name(SESSION_COOKIE_NAME.to_string())61                    .session_lifecycle(PersistentSession::default().session_ttl(Duration::days(30)))62                    .build(),63                )64                .app_data(web::Data::new($db))65                .app_data(web::Data::new($config))66                .configure(crate::configure_routes),67        )68        .await69    };70}7172fn session_token(resp: &actix_web::dev::ServiceResponse) -> Option<String> {73    resp.response()74        .cookies()75        .find(|c| c.name() == SESSION_COOKIE_NAME)76        .map(|c| c.value().to_string())77}7879async fn body_string(resp: actix_web::dev::ServiceResponse) -> String {80    let bytes = aw_test::read_body(resp).await;81    String::from_utf8(bytes.to_vec()).expect("utf-8 body")82}8384#[actix_web::test]85async fn test_signup_login_and_add_a_private_task() {86    let (db, config, db_path) = setup().await;87    let app = test_app!(db.clone(), config);8889    // Sign up.90    let req = aw_test::TestRequest::post()91        .uri("/auth/signup")92        .insert_header(("HX-Request", "true"))93        .set_form(Signup {94            username: "alice",95            email: "alice@example.com",96            password: "password123",97            invite: "test-invite",98        })99        .to_request();100    let resp = aw_test::call_service(&app, req).await;101    assert!(resp.status().is_success());102    assert!(body_string(resp).await.contains("Account created"));103104    // Log in and capture the session cookie.105    let req = aw_test::TestRequest::post()106        .uri("/auth/login")107        .insert_header(("HX-Request", "true"))108        .set_form(Login {109            username: "alice",110            password: "password123",111        })112        .to_request();113    let resp = aw_test::call_service(&app, req).await;114    assert!(resp.status().is_success());115    assert_eq!(116        resp.headers().get("HX-Redirect").unwrap(),117        "/",118        "successful login redirects home"119    );120    let token = session_token(&resp).expect("login sets a session cookie");121    let cookie = Cookie::new(SESSION_COOKIE_NAME, token);122123    // Tasks stand alone and can have optional tags.124    let req = aw_test::TestRequest::post()125        .uri("/tickets")126        .cookie(cookie.clone())127        .insert_header(("Content-Type", "application/x-www-form-urlencoded"))128        .set_payload("title=Keep+this+private&new_tags=personal%2C+today")129        .to_request();130    let resp = aw_test::call_service(&app, req).await;131    assert_eq!(resp.status(), StatusCode::SEE_OTHER);132133    // Visitors see the done counter and login, never private task details.134    let req = aw_test::TestRequest::get().uri("/").to_request();135    let body = body_string(aw_test::call_service(&app, req).await).await;136    assert!(body.contains("0</strong>") && body.contains("tickets"));137    assert!(body.contains("me.silenlocatelli.ch"));138    assert!(body.contains("/auth/login"));139    assert!(!body.contains("Keep this private"));140141    // Only its creator sees the task and its tags.142    let req = aw_test::TestRequest::get()143        .uri("/")144        .cookie(cookie)145        .to_request();146    let body = body_string(aw_test::call_service(&app, req).await).await;147    assert!(body.contains("Keep this private"));148    assert!(body.contains("#personal") && body.contains("#today"));149150    cleanup(&db_path);151}152153#[actix_web::test]154async fn test_done_and_not_planned_are_distinct_closed_outcomes() {155    let (db, config, db_path) = setup().await;156    let app = test_app!(db.clone(), config);157158    let req = aw_test::TestRequest::post()159        .uri("/auth/signup")160        .insert_header(("HX-Request", "true"))161        .set_form(Signup {162            username: "alice",163            email: "alice@example.com",164            password: "password123",165            invite: "test-invite",166        })167        .to_request();168    aw_test::call_service(&app, req).await;169    let req = aw_test::TestRequest::post()170        .uri("/auth/login")171        .insert_header(("HX-Request", "true"))172        .set_form(Login {173            username: "alice",174            password: "password123",175        })176        .to_request();177    let resp = aw_test::call_service(&app, req).await;178    let cookie = Cookie::new(179        SESSION_COOKIE_NAME,180        session_token(&resp).expect("session cookie"),181    );182183    let user = db.get_user_by_username("alice").await.unwrap().unwrap();184    let req = aw_test::TestRequest::post()185        .uri("/tickets")186        .cookie(cookie.clone())187        .insert_header(("Content-Type", "application/x-www-form-urlencoded"))188        .set_payload("title=Write+the+outline&new_tags=writing%2C+important")189        .to_request();190    assert_eq!(191        aw_test::call_service(&app, req).await.status(),192        StatusCode::SEE_OTHER193    );194    let req = aw_test::TestRequest::post()195        .uri("/tickets")196        .cookie(cookie.clone())197        .insert_header(("Content-Type", "application/x-www-form-urlencoded"))198        .set_payload("title=Maybe+learn+the+harp")199        .to_request();200    assert_eq!(201        aw_test::call_service(&app, req).await.status(),202        StatusCode::SEE_OTHER203    );204205    let tasks = db.visible_tickets(Some(&user.id)).await.unwrap();206    assert_eq!(tasks.len(), 2);207    let done_id = tasks208        .iter()209        .find(|item| item.ticket.title == "Write the outline")210        .unwrap()211        .ticket212        .id213        .clone();214    let unplanned_id = tasks215        .iter()216        .find(|item| item.ticket.title == "Maybe learn the harp")217        .unwrap()218        .ticket219        .id220        .clone();221    let writing_tag = tasks222        .iter()223        .find(|item| item.ticket.id == done_id)224        .unwrap()225        .tags226        .iter()227        .find(|tag| tag.name == "writing")228        .unwrap()229        .id230        .clone();231    assert!(db.visible_tickets(None).await.unwrap().is_empty());232233    let req = aw_test::TestRequest::get()234        .uri(&format!("/?tag={writing_tag}"))235        .cookie(cookie.clone())236        .to_request();237    let body = body_string(aw_test::call_service(&app, req).await).await;238    assert!(body.contains("Write the outline"));239    assert!(!body.contains("Maybe learn the harp"));240241    let req = aw_test::TestRequest::post()242        .uri(&format!("/tickets/{done_id}/close"))243        .cookie(cookie.clone())244        .insert_header(("Content-Type", "application/x-www-form-urlencoded"))245        .set_payload("outcome=done")246        .to_request();247    assert_eq!(248        aw_test::call_service(&app, req).await.status(),249        StatusCode::SEE_OTHER250    );251    let req = aw_test::TestRequest::post()252        .uri(&format!("/tickets/{unplanned_id}/close"))253        .cookie(cookie.clone())254        .insert_header(("Content-Type", "application/x-www-form-urlencoded"))255        .set_payload("outcome=not_planned")256        .to_request();257    assert_eq!(258        aw_test::call_service(&app, req).await.status(),259        StatusCode::SEE_OTHER260    );261    assert_eq!(db.done_ticket_count(&user.id).await.unwrap(), 1);262    let req = aw_test::TestRequest::get()263        .uri("/?view=closed")264        .cookie(cookie.clone())265        .to_request();266    let body = body_string(aw_test::call_service(&app, req).await).await;267    assert!(body.contains("Write the outline") && body.contains("Maybe learn the harp"));268    assert!(body.contains("Not planned"));269    assert!(body.contains("done"));270    assert!(!body.contains("XP") && !body.contains("Level 1"));271272    // A closed ticket cannot be counted again unless it is reopened.273    assert!(!db.close_ticket(&done_id, &user.id, "done").await.unwrap());274    assert_eq!(db.done_ticket_count(&user.id).await.unwrap(), 1);275    assert!(db.reopen_ticket(&unplanned_id, &user.id).await.unwrap());276    assert!(277        db.close_ticket(&unplanned_id, &user.id, "done")278            .await279            .unwrap()280    );281    assert_eq!(db.done_ticket_count(&user.id).await.unwrap(), 2);282283    cleanup(&db_path);284}285286#[actix_web::test]287async fn test_signup_requires_a_valid_invite() {288    let (db, mut config, db_path) = setup().await;289    config.invite_secret = None;290    let app = test_app!(db.clone(), config);291292    let req = aw_test::TestRequest::get().uri("/auth/login").to_request();293    let body = body_string(aw_test::call_service(&app, req).await).await;294    assert!(!body.contains("/auth/invites"));295296    let req = aw_test::TestRequest::get().uri("/auth/signup").to_request();297    assert_eq!(298        aw_test::call_service(&app, req).await.status(),299        StatusCode::NOT_FOUND300    );301302    let req = aw_test::TestRequest::post()303        .uri("/auth/signup")304        .set_form(Signup {305            username: "alice",306            email: "alice@example.com",307            password: "password123",308            invite: "not-a-valid-invite",309        })310        .to_request();311    assert_eq!(312        aw_test::call_service(&app, req).await.status(),313        StatusCode::NOT_FOUND314    );315316    cleanup(&db_path);317}318319#[actix_web::test]320async fn test_signup_rejects_invalid_invite() {321    let (db, config, db_path) = setup().await;322    let app = test_app!(db, config);323324    let req = aw_test::TestRequest::post()325        .uri("/auth/signup")326        .set_form(Signup {327            username: "alice",328            email: "alice@example.com",329            password: "password123",330            invite: "wrong-token",331        })332        .to_request();333    assert_eq!(334        aw_test::call_service(&app, req).await.status(),335        StatusCode::NOT_FOUND336    );337338    cleanup(&db_path);339}340341#[actix_web::test]342async fn test_invite_secret_creates_a_one_time_signup_link() {343    let (db, config, db_path) = setup().await;344    let app = test_app!(db.clone(), config);345346    let req = aw_test::TestRequest::post()347        .uri("/auth/invites")348        .insert_header(("HX-Request", "true"))349        .set_form(CreateInvite {350            invite_secret: "test-invite-secret",351        })352        .to_request();353    let resp = aw_test::call_service(&app, req).await;354    assert!(resp.status().is_success());355    let body = body_string(resp).await;356    let link_start =357        body.find("/auth/signup?invite=").expect("invite link") + "/auth/signup?invite=".len();358    let invite = &body[link_start..body[link_start..].find('"').unwrap() + link_start];359360    let req = aw_test::TestRequest::get()361        .uri(&format!("/auth/signup?invite={invite}"))362        .to_request();363    assert!(aw_test::call_service(&app, req).await.status().is_success());364365    let signup = || {366        aw_test::TestRequest::post()367            .uri("/auth/signup")368            .insert_header(("HX-Request", "true"))369            .set_form(Signup {370                username: "invited-user",371                email: "invited@example.com",372                password: "password123",373                invite,374            })375            .to_request()376    };377    let resp = aw_test::call_service(&app, signup()).await;378    assert!(resp.status().is_success());379    assert!(body_string(resp).await.contains("Account created"));380    assert_eq!(381        aw_test::call_service(&app, signup()).await.status(),382        StatusCode::NOT_FOUND383    );384385    cleanup(&db_path);386}387388#[actix_web::test]389async fn test_private_ticket_is_hidden_from_others() {390    let (db, config, db_path) = setup().await;391    let app = test_app!(db.clone(), config);392393    // Two users.394    for (index, (username, email)) in [("alice", "alice@example.com"), ("bob", "bob@example.com")]395        .into_iter()396        .enumerate()397    {398        let invite = format!("invite-{index}");399        db.create_invite(&invite).await.unwrap();400        let req = aw_test::TestRequest::post()401            .uri("/auth/signup")402            .insert_header(("HX-Request", "true"))403            .set_form(Signup {404                username,405                email,406                password: "password123",407                invite: &invite,408            })409            .to_request();410        assert!(aw_test::call_service(&app, req).await.status().is_success());411    }412413    let login = |username: &'static str| async {414        let req = aw_test::TestRequest::post()415            .uri("/auth/login")416            .insert_header(("HX-Request", "true"))417            .set_form(Login {418                username,419                password: "password123",420            })421            .to_request();422        let resp = aw_test::call_service(&app, req).await;423        Cookie::new(424            SESSION_COOKIE_NAME,425            session_token(&resp).expect("session cookie"),426        )427    };428429    let alice = login("alice").await;430    let bob = login("bob").await;431432    let req = aw_test::TestRequest::post()433        .uri("/tickets")434        .cookie(alice.clone())435        .insert_header(("Content-Type", "application/x-www-form-urlencoded"))436        .set_payload("title=Alice%27s+private+note")437        .to_request();438    assert_eq!(439        aw_test::call_service(&app, req).await.status(),440        StatusCode::SEE_OTHER441    );442443    // A different logged-in user and an anonymous visitor never receive it.444    for cookie in [Some(bob), None] {445        let mut req = aw_test::TestRequest::get().uri("/");446        if let Some(cookie) = cookie {447            req = req.cookie(cookie);448        }449        let body = body_string(aw_test::call_service(&app, req.to_request()).await).await;450        assert!(!body.contains("private note"));451    }452    assert_eq!(db.all_done_ticket_count().await.unwrap(), 0);453454    cleanup(&db_path);455}456457#[actix_web::test]458async fn test_login_rejects_bad_credentials() {459    let (db, config, db_path) = setup().await;460    let app = test_app!(db.clone(), config);461462    let req = aw_test::TestRequest::post()463        .uri("/auth/login")464        .insert_header(("HX-Request", "true"))465        .set_form(Login {466            username: "nobody",467            password: "password123",468        })469        .to_request();470    let resp = aw_test::call_service(&app, req).await;471    assert_eq!(resp.status(), StatusCode::UNAUTHORIZED);472    assert!(session_token(&resp).is_none());473474    cleanup(&db_path);475}476477#[actix_web::test]478async fn test_ticket_log_requires_login() {479    let (db, config, db_path) = setup().await;480    let app = test_app!(db.clone(), config);481482    let req = aw_test::TestRequest::post()483        .uri("/tickets")484        .insert_header(("Content-Type", "application/x-www-form-urlencoded"))485        .set_payload("title=Nope")486        .to_request();487    let resp = aw_test::call_service(&app, req).await;488    assert_eq!(resp.status(), StatusCode::SEE_OTHER);489    assert_eq!(resp.headers().get("Location").unwrap(), "/");490491    let req = aw_test::TestRequest::get()492        .uri("/tickets")493        .insert_header(("HX-Request", "true"))494        .to_request();495    let resp = aw_test::call_service(&app, req).await;496    assert_eq!(resp.status(), StatusCode::SEE_OTHER);497498    cleanup(&db_path);499}500501#[actix_web::test]502async fn test_logout_clears_session() {503    let (db, config, db_path) = setup().await;504    let app = test_app!(db.clone(), config);505506    let req = aw_test::TestRequest::post()507        .uri("/auth/signup")508        .insert_header(("HX-Request", "true"))509        .set_form(Signup {510            username: "alice",511            email: "alice@example.com",512            password: "password123",513            invite: "test-invite",514        })515        .to_request();516    assert!(aw_test::call_service(&app, req).await.status().is_success());517518    let req = aw_test::TestRequest::post()519        .uri("/auth/login")520        .insert_header(("HX-Request", "true"))521        .set_form(Login {522            username: "alice",523            password: "password123",524        })525        .to_request();526    let resp = aw_test::call_service(&app, req).await;527    let token = session_token(&resp).expect("session cookie");528    let cookie = Cookie::new(SESSION_COOKIE_NAME, token.clone());529530    let req = aw_test::TestRequest::post()531        .uri("/auth/logout")532        .cookie(cookie)533        .insert_header(("HX-Request", "true"))534        .to_request();535    let resp = aw_test::call_service(&app, req).await;536    assert_eq!(resp.status(), StatusCode::OK);537538    let mut rows = db539        .conn()540        .await541        .unwrap()542        .query("SELECT COUNT(*) FROM sessions", ())543        .await544        .unwrap();545    let count = rows.next().await.unwrap().unwrap().get::<i64>(0).unwrap();546    assert_eq!(count, 0, "logout must delete the server-side session");547548    cleanup(&db_path);549}